OSDev.org

h0bby1 wrote:

Code: Select all

int *current_lock=&lock.current_lock;

if((*current_lock)!=0)
{
   add_this_thread_to_queue(lock);
   wait();
}

(*current_lock)=this_thread

logically there is nothing that would prevent the compiler to put the (*current_lock)=this_thread before the wait

Kevin wrote:

h0bby1 wrote:

Code: Select all

int *current_lock=&lock.current_lock;

if((*current_lock)!=0)
{
   add_this_thread_to_queue(lock);
   wait();
}

(*current_lock)=this_thread

logically there is nothing that would prevent the compiler to put the (*current_lock)=this_thread before the wait

Except that it probably doesn't know whether add_this_thread_to_queue() or wait() can access current_lock or *current_lock, so in practice it can't reorder. (And if it knew the answer, it would probably be "yes", so it wouldn't be able to reorder either.)

struct lock
{
   unsigned int current_lock;
   array           queue;
};

void add_this_thread_to_queue(array queue)
{
    queue.add(this_thread);
}
void wait()
{

}

void lock(struct *lock)
{

int *current_lock=&lock->current_lock;
int c_lock;

c_lock=(*current_lock);

if(c_lock!=0)
{
   add_this_thread_to_queue(&lock->queue);
   wait();
}

(*current_lock)=this_thread;

(*current_lock)=this_thread;

c_lock=(*current_lock);