OSDev.org

SoulofDeity wrote:I stated in my first post that I wasn't going to build a GCC cross compiler, and politely asked that people not even suggest it.

Jezze wrote:You've got 12 cpus!?

Hobbes wrote:

SoulofDeity wrote:I stated in my first post that I wasn't going to build a GCC cross compiler, and politely asked that people not even suggest it.

"Some questions are logically nonsensical because the querent thinks they know more than they do. A lot of these have the form ‘How do I use X to accomplish Y?’ There's nothing wrong with this, except that sometimes X is a chocolate-covered banana and Y is the integration of European currency systems."

Put down the chocolate-covered banana and step away from the European currency systems.

SoulofDeity wrote:Take for example libpng. There's a ton of different instructions for reading the file through filters, having to read signatures, allocating and struct and info pointers, etc. Why make it so complicated? Just make a function "png_readImage(void *buffer, int width, int height, int line)".

class PREFIX_PNGFile : public PREFIX_ImageFile {
public:
    virtual void close();
    virtual int  load ( const char* file );
};

bluemoon wrote:

SoulofDeity wrote:Take for example libpng. There's a ton of different instructions for reading the file through filters, having to read signatures, allocating and struct and info pointers, etc. Why make it so complicated? Just make a function "png_readImage(void *buffer, int width, int height, int line)".

I'm not commenting on the code quality of libpng, I appreciate their effort, after all it's free.
My opinion is when deal with 3rd party libraries, always abstract(ie. warp) it with an interface and work with that interface for the rest of your project. The side-effect is that no matter how messy or complicate the libraries is, you only need to directly use it once.

Take libpng as an example, I have a general image reader class looks like this, which looks pretty standard and used by most programmers:

Code: Select all

class PREFIX_PNGFile : public PREFIX_ImageFile {
public:
    virtual void close();
    virtual int  load ( const char* file );
};

But do a single png_readImage(void *buffer, int width, int height, int line), or a single interface fits everyone? No.

when dealing with android, things are stored inside ZIP file (apk file). So the resource loader need to take care of the file source (being standard file or within zip file).
In that case, thanks for the libpng functions are flexible and I can handle it with calls to png_set_read_fn(png_ptr, zfp, png_zip_read); and modify the above C++ class interface.

SoulofDeity wrote:I wasn't saying building a cross-compiler is wrong, I was just asking for an alternative solution.