Here's my Input Context initialization (I've created a struct with bitfileds for debugging):BenLunt wrote:Hi guys,
Sorry I haven't been around this forum too much lately. I have been quite busy with other things as well as a new job.
As for the xHCI, make sure that your Slot and EP contexts are properly aligned and formatted. I have found that even a slight irregularity in the EP context will make a device stall.
Also, is your keyboard really a full-speed device? That would surprise me. A mouse and a keyboard should be a low-speed device. Make sure you have indicated this correctly in the Slot and EP context data. This will make a difference in the xHCI's bandwidth calculations.
Sorry I don't have much more time to help you with this. Hopefully things start to slow down a bit and I can come back to this forum more frequently.
Ben
- http://www.fysnet.net/the_universal_serial_bus.htm
Code: Select all
bool createSlotContext(size_t portspeed, xhci_port_info* pinfo)
{
//Allocate input context
paddr_t incontext = pmmngr_allocate(1);
volatile input_context* mapincontxt = (input_context*)find_free_paging(PAGESIZE);
paging_map((void*)mapincontxt, incontext, PAGESIZE, PAGE_ATTRIBUTE_WRITABLE | PAGE_ATTRIBUTE_NO_CACHING);
memset((void*)mapincontxt, 0, PAGESIZE);
//Set input control context
mapincontxt->AddContext = 3;
//Setup slot context
mapincontxt->SlotContext.rootHubPort = pinfo->portindex;
mapincontxt->SlotContext.routeString = 0;
mapincontxt->SlotContext.ContextEntries = 1;
mapincontxt->SlotContext.speed = portspeed;
//Initialise endpoint 0 context
//Control endpoint, CErr = 3
mapincontxt->EndpointContexts[0].MaxPacketSize = max_packet_size(portSpeed(portspeed));
mapincontxt->EndpointContexts[0].EPType = 4; //Control
mapincontxt->EndpointContexts[0].TRDequeuePtr = pinfo->cmdring.getBaseAddress() | 1;
mapincontxt->EndpointContexts[0].Cerr = 3;
mapincontxt->EndpointContexts[0].AvgTRBLength = 8;
mapincontxt->EndpointContexts[0].MaxBurstSize = 0;
mapincontxt->EndpointContexts[0].MaxESITPayloadLow = mapincontxt->EndpointContexts[0].MaxPacketSize * (mapincontxt->EndpointContexts[0].MaxBurstSize + 1);
//Allocate device context
paddr_t dctxt = pmmngr_allocate(1);
void* mapdctxt = find_free_paging(PAGESIZE);
paging_map(mapdctxt, dctxt, PAGESIZE, PAGE_ATTRIBUTE_WRITABLE | PAGE_ATTRIBUTE_NO_CACHING);
memset(mapdctxt, 0, PAGESIZE);
//Write to device context array slot
*raw_offset<volatile uint64_t*>(devctxt, pinfo->slotid * 8) = dctxt;
//Issue address device command
void* last_command = cmdring.enqueue(create_address_command(true, incontext, pinfo->slotid));
uint64_t* curevt = (uint64_t*)waitComplete(last_command, 1000);
if (get_trb_completion_code(curevt) != XHCI_COMPLETION_SUCCESS)
{
kprintf(u"Error addressing device\n");
return false;
}
pinfo->device_context = mapdctxt;
//If the device is full speed, we need to work out the correct packet size
if (portSpeed(portspeed) == FULL_SPEED)
{
//kprintf(u"Full speed device, calculating packet size\n");
if (!update_packet_size_fs(pinfo))
return false;
}
last_command = cmdring.enqueue(create_address_command(false, incontext, pinfo->slotid));
curevt = (uint64_t*)waitComplete(last_command, 1000);
if (get_trb_completion_code(curevt) != XHCI_COMPLETION_SUCCESS)
{
kprintf(u"Error addressing device\n");
return false;
}
return true;
}Remember that there is a machine page, which probably is 4096 in size, and there is an xHCI page, which might be 4096 bytes in size, but could be different. The xHCI will indicate the size for you.bellezzasolo wrote: Alignment can't be an issue, give that it's page aligned.
I wouldn't trust this. Windows is probably just indicating that it is of the Low-, Full-speed era of the USB. USB 1.1 had a max speed of Full-speed, so it displays that.bellezzasolo wrote: Regarding the speed of my keyboard, HwInfo reports the following on Windows:
USB Version Supported: 2.00
USB Device Speed: USB 1.1 Full-speed
Code: Select all
May 3 17:55:49 nathaniel-desktoplin kernel: [ 1.383751] xhci_hcd 0000:00:14.0: xHCI Host Controller
May 3 17:55:49 nathaniel-desktoplin kernel: [ 1.383753] xhci_hcd 0000:00:14.0: new USB bus registered, assigned bus number 1
May 3 17:55:49 nathaniel-desktoplin kernel: [ 1.384822] xhci_hcd 0000:00:14.0: hcc params 0x200077c1 hci version 0x110 quirks 0x0000000000009810
May 3 17:55:49 nathaniel-desktoplin kernel: [ 1.384829] xhci_hcd 0000:00:14.0: cache line size of 64 is not supported
May 3 17:55:49 nathaniel-desktoplin kernel: [ 1.724050] usb 1-3: new full-speed USB device number 2 using xhci_hcd
May 3 17:55:49 nathaniel-desktoplin kernel: [ 1.878006] usb 1-3: New USB device found, idVendor=1130, idProduct=1620, bcdDevice= 1.87
May 3 17:55:49 nathaniel-desktoplin kernel: [ 1.878007] usb 1-3: New USB device strings: Mfr=0, Product=2, SerialNumber=0
May 3 17:55:49 nathaniel-desktoplin kernel: [ 1.878008] usb 1-3: Product: USB AUDIO
May 3 17:55:49 nathaniel-desktoplin kernel: [ 2.004052] usb 1-7: new full-speed USB device number 3 using xhci_hcd
May 3 17:55:49 nathaniel-desktoplin kernel: [ 2.158641] usb 1-7: New USB device found, idVendor=0518, idProduct=5111, bcdDevice= 2.01
May 3 17:55:49 nathaniel-desktoplin kernel: [ 2.158642] usb 1-7: New USB device strings: Mfr=1, Product=2, SerialNumber=0
May 3 17:55:49 nathaniel-desktoplin kernel: [ 2.158642] usb 1-7: Product: USB Gaming Keyboard
May 3 17:55:49 nathaniel-desktoplin kernel: [ 2.158643] usb 1-7: Manufacturer: E-Signal
May 3 17:55:49 nathaniel-desktoplin kernel: [ 2.288149] usb 1-8: new full-speed USB device number 4 using xhci_hcd
May 3 17:55:49 nathaniel-desktoplin kernel: [ 3.086150] usb 1-8: New USB device found, idVendor=04d9, idProduct=a0d6, bcdDevice= 1.05
May 3 17:55:49 nathaniel-desktoplin kernel: [ 3.086150] usb 1-8: New USB device strings: Mfr=1, Product=2, SerialNumber=0
May 3 17:55:49 nathaniel-desktoplin kernel: [ 3.086151] usb 1-8: Product: USB Gaming Mouse
May 3 17:55:49 nathaniel-desktoplin kernel: [ 3.086152] usb 1-8: Manufacturer: E-Signal/A-One