OSDev.org

1. Tabs. Add some tabs within the function blocks and so on, so that you (or rather, other people) can see the flow of the code properly. It doesn't matter whether you use tabs or spaces, but using neither is a sin.
2. Same thing for comments. Add some, it'll improve readability a lot. We'd like to know what, how and why a function does something, though if the code is clear enough sometimes the how part can be left out.
3. Whitespace. Put space between the functions, different blocks, parts of a block that do different things. It just breaks it up and makes it easier to read.

purage wrote:You should further develop the malloc (and not call it malloc) function to actually reserve the memory as well. A check to see if you are out of memory would be nice too.

int address = 0x00F;
void *m_malloc(int size){
address = address + size+3;
return ((void *)address);
}
void m_free(char *p){
if(p){
p = (char *) 0x00;
 }
}

int address = 0x00F;

void *m_malloc(int size)
{
	return ((void*)address += size);
}

void m_free(void *p)
{
}

Troy Martin wrote:They appear to work at a glance of the code, but they're extremely simple.

Troy Martin wrote:

Code: Select all

<Mr_Piranha> int strlen(char *s)
 <Mr_Piranha> {
 <Mr_Piranha>  char *o;
 <Mr_Piranha>  o=s;
 <Mr_Piranha>  if(*s)
 <Mr_Piranha>  {
 <Mr_Piranha>   while(1)
 <Mr_Piranha>   {
 <Mr_Piranha>    if(*s) s++;
 <Mr_Piranha>    else
 <Mr_Piranha>     break;
 <Mr_Piranha>   }
 <Mr_Piranha>   
 <Mr_Piranha>  }
 <Mr_Piranha>  return (int)(s-o);
 <Mr_Piranha> }
 <Mr_Piranha> heh heh