Oppinion: Flesh-Out of SFS Article

All about the OSDev Wiki. Discussions about the organization and general structure of articles and how to use the wiki. Request changes here if you don't know how to use the wiki.
Post Reply
User avatar
thepowersgang
Member
Member
Posts: 734
Joined: Tue Dec 25, 2007 6:03 am
Libera.chat IRC: thePowersGang
Location: Perth, Western Australia
Contact:

Oppinion: Flesh-Out of SFS Article

Post by thepowersgang »

I've just finished embellishing the SFS article and I want an opinion on how it looks and how it could be improved.

Link: SFS
Kernel Development, It's the brain surgery of programming.
Acess2 OS (c) | Tifflin OS (rust) | mrustc - Rust compiler
Currently Working on: mrustc
User avatar
Combuster
Member
Member
Posts: 9301
Joined: Wed Oct 18, 2006 3:45 am
Libera.chat IRC: [com]buster
Location: On the balcony, where I can actually keep 1½m distance
Contact:

Re: Oppinion: Flesh-Out of SFS Article

Post by Combuster »

I fixed some incorrect details (SFS can be a partition, names are UTF-8) but otherwise it looks good
"Certainly avoid yourself. He is a newbie and might not realize it. You'll hate his code deeply a few years down the road." - Sortie
[ My OS ] [ VDisk/SFS ]
User avatar
thepowersgang
Member
Member
Posts: 734
Joined: Tue Dec 25, 2007 6:03 am
Libera.chat IRC: thePowersGang
Location: Perth, Western Australia
Contact:

Re: Oppinion: Flesh-Out of SFS Article

Post by thepowersgang »

Thanks, the spec is a little bit confusing on where the super-block actually is but I presumed it to reside in the MBR because it had space for the partition table. Maybe the spec should be updated to explicitly state the where the super-block should be.
Kernel Development, It's the brain surgery of programming.
Acess2 OS (c) | Tifflin OS (rust) | mrustc - Rust compiler
Currently Working on: mrustc
User avatar
Combuster
Member
Member
Posts: 9301
Joined: Wed Oct 18, 2006 3:45 am
Libera.chat IRC: [com]buster
Location: On the balcony, where I can actually keep 1½m distance
Contact:

Re: Oppinion: Flesh-Out of SFS Article

Post by Combuster »

The space for the partition table is there because logical volumes have a partition table too.

If you read the specification correctly, it refers to the 'storage medium' as a general concept to refer to a place to store data. Wether that is the entire disk, or a part of the disk is not mentioned. Attempting to do so would result in incompleteness since one can't possibly know all forms of data storage and their organisation. The only thing that happens is that space is reserved for when specific areas of sector 0 are required.

For comparison, ISO 9660 only describes a filesystem on a CD. When you burn a CD a TOC, lead-in and lead-out are added since they are required by the CD standard. Hence the filesystem does not start at location 0 on disk. The same holds for partitions on harddisks.

None of the other FS specs I have looked at mention that they should start at physical location 0 either, but rather imply the medium to be the location where the FS is located.
"Certainly avoid yourself. He is a newbie and might not realize it. You'll hate his code deeply a few years down the road." - Sortie
[ My OS ] [ VDisk/SFS ]
Post Reply