[Solved] put pixel to get pixel and gui scroll

[shmx]

No hope. This is just impossible to solve.

I do not see your attempts to do so.

[shmx]

How do I capture 1600x900x32 area of pixels, save those pixels to a buffer and shift their y coordinate by wanted amount?

Why do you want intermediate buffer? Is not it easier to copy to the right place at once?

Code: Select all

void CopyMem(const DWORD* InBuf, DWORD* OutBuf, size_t Len, int Dir)
{
    size_t i;
    if(Dir == 0)
    {
        for(i = 0; i < Len; i++, OutBuf++, InBuf++)
             *OutBuf = *InBuf;
    }
    else
    {
        for(i = 0; i < Len; i++, OutBuf--, InBuf--)
            *OutBuf = *InBuf;
    }
}

void CopyRectangle(const DWORD *InVideoBuffer, DWORD *OutVideoBuffer,
    int X1, int Y1, int X2, int Y2, int Width, int Height,
    int Buffer1_Pitch, int Buffer2_Pitch)
{
	const DWORD* vbuf1;
    DWORD* vbuf2;
    int y = Height;

	if(Y2 <= Y1)
	{
		if(X2 <= X1)
		{
			vbuf1 = InVideoBuffer + X1 + Y1 * Buffer1_Pitch;
			vbuf2 = OutVideoBuffer + X2 + Y2 * Buffer2_Pitch;
			while(y-- > 0)
			{
                CopyMem(vbuf1, vbuf2, Width, 0);
				vbuf1 += Buffer1_Pitch;
				vbuf2 += Buffer2_Pitch;
			}
			
		}
		else
		{
			vbuf1 = InVideoBuffer + X1 + Width - 1 + Y1 * Buffer1_Pitch;
			vbuf2 = OutVideoBuffer + X2 + Width - 1 + Y2 * Buffer2_Pitch;
			while(y--)
			{
				CopyMem(vbuf1, vbuf2, Width, 1);
				vbuf1 += Buffer1_Pitch;
				vbuf2 += Buffer2_Pitch;
			}
		}
	}
	else
	{
		if(X2 <= X1)
		{
			vbuf1 = InVideoBuffer + X1 + (Y1 + Height - 1) * Buffer1_Pitch;
			vbuf2 = OutVideoBuffer + X2 + (Y2 + Height - 1) * Buffer2_Pitch;
			while(y--)
			{
			    CopyMem(vbuf1, vbuf2, Width, 0);
				vbuf1 -= Buffer1_Pitch;
				vbuf2 -= Buffer2_Pitch;
			}
		}
		else
		{
			vbuf1 = InVideoBuffer + X1 + Width - 1 + (Y1 + Height - 1) * Buffer1_Pitch;
			vbuf2 = OutVideoBuffer + X2 + Width - 1 + (Y2 + Height - 1) * Buffer2_Pitch;
			while(y--)
			{
				CopyMem(vbuf1, vbuf2, Width, 1);
				vbuf1 -= Buffer1_Pitch;
				vbuf2 -= Buffer2_Pitch;
			}
		}
	}
}

Something like this. InVideoBuffer can be equal OutVideoBuffer.
Pitch - logical buffer width (may be more than simply width).

[BrightLight]

Just as a note, you should NEVER read from the VESA framebuffer. Writing is slow enough. Reading is even slower. Allocate a back buffer in normal RAM, and read from there and operate how you like on it. When all drawing is done, you memcpy() the back buffer to the hardware framebuffer.
Double Buffering

[Octacone]

Just as a note, you should NEVER read from the VESA framebuffer. Writing is slow enough. Reading is even slower. Allocate a back buffer in normal RAM, and read from there and operate how you like on it. When all drawing is done, you memcpy() the back buffer to the hardware framebuffer.
Double Buffering

I have to admit something... That was one of the easiest to understand tutorials I've ever seen. for the author.
I did not know that it was that bad. I guess I will have to implement double buffering first and the get come in here.

[Octacone]

Is this how double buffering is supposed to look like?

Code: Select all

backVideoBuffer = ((uint32_t*) (Malloc(5760000))); //When I do this my mode does not get set
backVideoBuffer = ((uint32_t*) (Malloc(576000))); //When I do is with one less zero I get those artifacts

[Ch4ozz]

Looks like broken memory management if the usage of the buffer is right.
Anyways, you should clear the buffer before using it because memory is usually not 0

[Octacone]

Looks like broken memory management if the usage of the buffer is right.
Anyways, you should clear the buffer before using it because memory is usually not 0

Broken memory management. RIP!!!
What could it be: Malloc or MemoryCopy?

Here is my memory copy function:

Code: Select all

void MemoryCopy(string source, string destination, int bytes)
{
	for(int i = 0; i < bytes; ++i)
	*(destination + i) = *(source + i);
}

[Ch4ozz]

Broken memory management. RIP!!!
What could it be: Malloc or MemoryCopy?

Here is my memory copy function:

Code: Select all

void MemoryCopy(string source, string destination, int bytes)
{
	for(int i = 0; i < bytes; ++i)
	*(destination + i) = *(source + i);
}

The probem is usually a wrong implementation of malloc.
Your memcpy is the slowest possible method btw (moving windows will lag like hell with this thing)

[azblue]

The problem is: getting pixels from selected region.

It is simply copying memory. I do not understand what could be the problem.

I only know how to put pixels using:

Code: Select all

unsigned location = (position.Y * screenWidthBGA * 4) + (position.X * 4);
	linearFrameBufferBGA[location + 0] = 0;
	linearFrameBufferBGA[location + 2] = color.R;
	linearFrameBufferBGA[location + 1] = color.G;
	linearFrameBufferBGA[location + 0] = color.B;

I don't know how to get specific pixels from wanted location.

I don't understand how you can possibly know how to plot pixels but not get them. You read the locations you would otherwise write.

[Octacone]

Broken memory management. RIP!!!
What could it be: Malloc or MemoryCopy?

Here is my memory copy function:

Code: Select all

void MemoryCopy(string source, string destination, int bytes)
{
	for(int i = 0; i < bytes; ++i)
	*(destination + i) = *(source + i);
}

The probem is usually a wrong implementation of malloc.
Your memcpy is the slowest possible method btw (moving windows will lag like hell with this thing)

Yeah I know. I tweaked it up a bit.

[Octacone]

It is simply copying memory. I do not understand what could be the problem.

It is much more complex than that.
Does not matter any more, topic closed.