OSDev.org

iansjack wrote:If you think you have fixed the bug, try doing a WriteChar() to position 0, 0.

	terminal_clrscr();
	terminal_writestring("[", WHITE, BLACK, 0, 0);
	terminal_writestring("Dixium OS", WHITE, LIGHT_BLUE, 1, 0);
	terminal_writestring("]", WHITE, BLACK, 10, 0);
	terminal_writestring("  Write string succesful.", WHITE, BLACK, 11, 0);

Octocontrabass wrote:Did you read iansjack's post? He said writechar(), not writestring().

DixiumOS wrote:

Octocontrabass wrote:This bug.

That isn't a bug

DixiumOS wrote:EDIT: It doesn't work.

zenzizenzicube wrote:

DixiumOS wrote:

Octocontrabass wrote:This bug.

That isn't a bug

DixiumOS wrote:EDIT: It doesn't work.

Read through it again, or check the values with a debugger to see the value that you're actually passinig to terminal_writechar.

Anyway, didn't we go through all of this already in your old project?

void terminal_writechar(unsigned char c, unsigned char fc, unsigned char bc, int x, int y)
{
	if (x == 80) {
		x = 0;
		y++;
	}
	if (x == 0) {
		x++;
	}
	uint16_t attribute = (bc << 4) | (fc & 0x0F);
	volatile uint16_t * loc;
	loc = (volatile uint16_t *)0xB8000 + (y * 80 + x - 1);
	*loc = c | (attribute << 8);
}

DixiumOS wrote: The hell are you doing with 0xB7FFE, GCC?
B8000 - 1 does not equal B7FFE.

DixiumOS wrote:EDIT: Finally got it working. Ya' little..

Octocontrabass wrote:

DixiumOS wrote:EDIT: Finally got it working. Ya' little..

No, you just added more bugs.

Use terminal_writechar() to put a character at 0,0 and at 1,1. They won't show up at the correct locations.

	terminal_clrscr();
	terminal_writechar_freestanding('a', WHITE, BLUE, 0, 0);
	terminal_writechar_freestanding('b', BLUE, WHITE, 1, 1);
	terminal_writestring_freestanding("I like potato!", BLUE, WHITE, 12, 12);

DixiumOS wrote:EDIT: After doing some testing, it seems the tty.c forgot something that incremented the value yet again by one. Now i need to remove 2 for it to work.

for (size_t i = 0; i < len; i++) {
	x++;
	terminal_writechar(data[i], fc, bc, x, y);
}