I can't get my VGA driver to work

[Octocontrabass]

Here is my code - this works:

I don't think it works. You defined framebuffer as a pointer to a 32-bit integer instead of an 8-bit integer, so you should see it plotting pixels at the wrong locations.

Sorry, but I am a little confused as to how to do this. Again, sorry for the beginner questions.

To access the second byte of the pixel, add 1 to the index. Like this:

Code: Select all

framebuffer[mbi->framebuffer_pitch * y + 4 * x + 1]

[Caffeine]

Here is my code - this works:

I don't think it works. You defined framebuffer as a pointer to a 32-bit integer instead of an 8-bit integer, so you should see it plotting pixels at the wrong locations.

Sorry, but I am a little confused as to how to do this. Again, sorry for the beginner questions.

To access the second byte of the pixel, add 1 to the index. Like this:

Code: Select all

framebuffer[mbi->framebuffer_pitch * y + 4 * x + 1]

Thanks! This worked! Sorry I didn't understand. When plotting more than 1 pixel there are these huge gaps between the pixels (See screenshot below). How do I fix this?

[Octocontrabass]

I already explained why the pixels are at the wrong locations.

You defined framebuffer as a pointer to a 32-bit integer instead of an 8-bit integer, so you should see it plotting pixels at the wrong locations.

[Caffeine]

I already explained why the pixels are at the wrong locations.

You defined framebuffer as a pointer to a 32-bit integer instead of an 8-bit integer, so you should see it plotting pixels at the wrong locations.

Is this a fix?

Code: Select all

framebuffer = (unsigned char *)mbi->framebuffer_addr;  // Get the framebuffer address

If so it still displays it in the wrong location. (I change it from unsigned int * to unsigned char*)

EDIT: Nevermind I understand now. It works! Thank you!

[Octocontrabass]

Did you change the type of the variable, or just the cast?

[Caffeine]

Did you change the type of the variable, or just the cast?

Both, it works now! Thank you!