Shell is not recognizing commands

[osdever]

All is fine, but the console is not recognizing commands, like that:
> test
>
instead of
> test
Working!
> .
The code is here:

Code: Select all

....
printw("> ",console);
char * cmd;
char c = 0;
int i=0;
do
{
if(inb(0x60)!=c)
{
c = inb(0x60);
if(c == 28)
{
if(cmd == "test")
kprint("working\n");
kprint("\n> ");
}
if(c>0)
{
cmd[i] = scancode[c+1];
terminal_putchar(scancode[c+1]);
}
}
}
i++;
}
while(c!=1); //exit when ESC is pressed

Where's my error?

[osdever]

P.S. printw is printing text in the window.

[iansjack]

You can't compare strings using "==". Take some time out to learn C.

[osdever]

You can't compare strings using "==". Take some time out to learn C.

But what i should do?

[iansjack]

Sorry, this is an OS development forum, not a place for elementary C tutorials.

[Roman]

You can't compare strings using "==". Take some time out to learn C.

But what i should do?

You sound like a troll.

[glauxosdev]

Edit: I have sent him some private messages to let him know how to come across OS development and this forum. If he continues to ask like that you know the rest... Don't worry.

Regards,
glauxosdev

[alexfru]

You can't compare strings using "==". Take some time out to learn C.

+1. Also, cmd doesn't point to allocated memory.

[KemyLand]

You smell like one of those Java guys who love Java-island coffee . If you had wrote your kernel in C++, you could have used classes, overloaded operators, etc etc, to create a automatic String class, just like std::string, although I have always looked away from the C model (do it all yourself and do it
with explicit code, and remember not to drink Java-coffee) and the C++ (at least standard) model (dynamic memory is infinite, let's waste it with a constant and fixed "Hello, World!" string!)