I have a suggestion about an wiki page.

All about the OSDev Wiki. Discussions about the organization and general structure of articles and how to use the wiki. Request changes here if you don't know how to use the wiki.
Post Reply
donggas90
Member
Member
Posts: 38
Joined: Fri Oct 17, 2014 12:07 pm

I have a suggestion about an wiki page.

Post by donggas90 »

I have a suggestion in PCI.

I had been worked PCI successfully by read that wiki but someone can be confuse such as me by just a 'word' so I want to make exact.

In top of Figure2, 3 and 4, the tables, 'register' need to change to 'byte' or 'byte offset', I think.

The word, 'register' already connote that 'size is 4bytes(32bits)' because already explained about register size before.
and the other table headers mean 32bits.
Thus, if remain that 'word' at that location, value of registers such as 00, 04, 08 and so on need to change to 0, 1, 2, 3 and so on.

In real code, if want to access 3rd register that has Class code, Subclass etc., do not use 08 as register value of Config register. Just use 2.
so changing the values is better.
User avatar
SpyderTL
Member
Member
Posts: 1074
Joined: Sun Sep 19, 2010 10:05 pm

Re: I have a suggestion about an wiki page.

Post by SpyderTL »

Normally, I would agree that Offset makes more sense than Register in this context. However, the problem is that "Register" is the terminology used in the PCI specifications, I believe.

So I'm fine with leaving it as-is. Maybe just change the column header to "Register (offset)"?
Project: OZone
Source: GitHub
Current Task: LIB/OBJ file support
"The more they overthink the plumbing, the easier it is to stop up the drain." - Montgomery Scott
Post Reply