Should we switch the default skin to Vector?

All about the OSDev Wiki. Discussions about the organization and general structure of articles and how to use the wiki. Request changes here if you don't know how to use the wiki.
Post Reply

The default wiki skin should be

Poll ended at Wed Jan 11, 2012 12:28 am

Vector
28
88%
Monobook
4
13%
 
Total votes: 32

User avatar
chase
Site Admin
Posts: 710
Joined: Wed Oct 20, 2004 10:46 pm
Libera.chat IRC: chase_osdev
Location: Texas
Discord: chase/matt.heimer
Contact:

Should we switch the default skin to Vector?

Post by chase »

Vector, included in mediawiki 1.18, is now the default skin for wikipedia. Would you guys like to switch? You can test with:
http://wiki.osdev.org/index.php?title=M ... kin=vector
http://wiki.osdev.org/index.php?title=M ... n=monobook
User avatar
xenos
Member
Member
Posts: 1121
Joined: Thu Aug 11, 2005 11:00 pm
Libera.chat IRC: xenos1984
Location: Tartu, Estonia
Contact:

Re: Should we switch the default skin to Vector?

Post by xenos »

It doesn't make much of a difference to me, since both skins look rather clear and structured. But I think personal preferences of registered wiki users are only a secondary issue, since one can simply change a different skin if one doesn't like the default.

The main difference I see between the two skins is the location of the search box. Since Wikipedia's default style is now Vector, people (and mostly newbies) get more and more used to the search box in the upper right corner, so I think the Vector style makes more sense.
Programmers' Hardware Database // GitHub user: xenos1984; OS project: NOS
User avatar
Owen
Member
Member
Posts: 1700
Joined: Fri Jun 13, 2008 3:21 pm
Location: Cambridge, United Kingdom
Contact:

Re: Should we switch the default skin to Vector?

Post by Owen »

Vector. As much as I wish that every wiki on the internet didn't have exactly the same theme... Vector is far better looking than Monobook

(Much like, in my opinion, the difference between SubSilver and ProSilver for phpBB)
CrypticalCode0
Member
Member
Posts: 81
Joined: Wed Nov 09, 2011 2:21 am
Location: Behind a keyboard located in The Netherlands

Re: Should we switch the default skin to Vector?

Post by CrypticalCode0 »

This poll seem rather one sided.

The point here is a bit about Aesthetics, should we really go all out with a discussion here?
User avatar
thepowersgang
Member
Member
Posts: 734
Joined: Tue Dec 25, 2007 6:03 am
Libera.chat IRC: thePowersGang
Location: Perth, Western Australia
Contact:

Re: Should we switch the default skin to Vector?

Post by thepowersgang »

As someone who strives to minimise UI usage (mostly because many applications break when run on a netbook due to lack of space) monobook is slightly better due to having a larger content space. That said, I can change my personal preferences, and it is a minuscule difference. Vector looks better, and seems to be a cleaner design (less sharp lines that draw the eye to non-important items).
Kernel Development, It's the brain surgery of programming.
Acess2 OS (c) | Tifflin OS (rust) | mrustc - Rust compiler
Currently Working on: mrustc
User avatar
gravaera
Member
Member
Posts: 737
Joined: Tue Jun 02, 2009 4:35 pm
Location: Supporting the cause: Use \tabs to indent code. NOT \x20 spaces.

Re: Should we switch the default skin to Vector?

Post by gravaera »

I like the current wiki style more, personally :O
17:56 < sortie> Paging is called paging because you need to draw it on pages in your notebook to succeed at it.
User avatar
Jezze
Member
Member
Posts: 395
Joined: Thu Jul 26, 2007 1:53 am
Libera.chat IRC: jfu
Contact:

Re: Should we switch the default skin to Vector?

Post by Jezze »

+1 Vector
Fudge - Simplicity, clarity and speed.
http://github.com/Jezze/fudge/
User avatar
chase
Site Admin
Posts: 710
Joined: Wed Oct 20, 2004 10:46 pm
Libera.chat IRC: chase_osdev
Location: Texas
Discord: chase/matt.heimer
Contact:

Re: Should we switch the default skin to Vector?

Post by chase »

Given the way the poll is trending I'll go ahead and make the switch. If you are still seeing the old (monobook) style then you need to modify your personal preferences.
User avatar
Love4Boobies
Member
Member
Posts: 2111
Joined: Fri Mar 07, 2008 5:36 pm
Location: Bucharest, Romania

Re: Should we switch the default skin to Vector?

Post by Love4Boobies »

While I do like the Vector theme better and have voted for it, I do have a little complaint about it (perhaps it's configurable, though?): While, looking through some random pages to see whether the theme works well for our purposes, I noticed that the font for source code and text snippets is too small. E.g., see the UEFI page.

EDIT: This seems to happen with Firefox (I currently use version 9.01) but not Chrome. I don't know about other browsers.
What does it say?
What does it say?
"Computers in the future may weigh no more than 1.5 tons.", Popular Mechanics (1949)
[ Project UDI ]
User avatar
xenos
Member
Member
Posts: 1121
Joined: Thu Aug 11, 2005 11:00 pm
Libera.chat IRC: xenos1984
Location: Tartu, Estonia
Contact:

Re: Should we switch the default skin to Vector?

Post by xenos »

Love4Boobies wrote:EDIT: This seems to happen with Firefox (I currently use version 9.01) but not Chrome. I don't know about other browsers.
I had a look at the same page with both the monobook and the vector skin and, strangely, there is no difference in the font sizes for the code examples. I use Firefox 9.0.1 on Ubuntu 10.04.

Maybe I found the reason for this behavior: The vector skin uses a font-family: monospace,"Courier New"; for formatting the code examples. Firefox allows configuring different default font sizes for fixed-width and variable-width fonts (Edit / Preferences / Contents / Fonts & Colors / Advanced). So I guess you have set different values here for fixed-width and variable-width fonts.
Programmers' Hardware Database // GitHub user: xenos1984; OS project: NOS
User avatar
Love4Boobies
Member
Member
Posts: 2111
Joined: Fri Mar 07, 2008 5:36 pm
Location: Bucharest, Romania

Re: Should we switch the default skin to Vector?

Post by Love4Boobies »

It's odd. The sizes were properly set---I did however set the minimum font size to 12 (rather than none) and that seems to have fixed the problem. The wiki should be readable with the defaults provided by Firefox, though. Not to mention that this has an adverse effect on other websites. I'm currently on my Windows box.
"Computers in the future may weigh no more than 1.5 tons.", Popular Mechanics (1949)
[ Project UDI ]
User avatar
chase
Site Admin
Posts: 710
Joined: Wed Oct 20, 2004 10:46 pm
Libera.chat IRC: chase_osdev
Location: Texas
Discord: chase/matt.heimer
Contact:

Re: Should we switch the default skin to Vector?

Post by chase »

Testing on a Windows 7 box, both Chrome and IE look fine. FF 9 has the problem of super tiny text.

Anyone want to try to modify the CSS and see if they can get it working for all 3 browsers?

http://wiki.osdev.org/MediaWiki:Common.css
http://wiki.osdev.org/MediaWiki:Vector.css
User avatar
Love4Boobies
Member
Member
Posts: 2111
Joined: Fri Mar 07, 2008 5:36 pm
Location: Bucharest, Romania

Re: Should we switch the default skin to Vector?

Post by Love4Boobies »

The page is protected so I can't edit it. Here is the fix, add it to Common.css:

Code: Select all

div.mw-geshi div
div.mw-geshi div pre,
span.mw-geshi,
pre.source-css,
pre.source-javascript {
    font-family: monospace, "Courier New" !important;
}
"Computers in the future may weigh no more than 1.5 tons.", Popular Mechanics (1949)
[ Project UDI ]
User avatar
chase
Site Admin
Posts: 710
Joined: Wed Oct 20, 2004 10:46 pm
Libera.chat IRC: chase_osdev
Location: Texas
Discord: chase/matt.heimer
Contact:

Re: Should we switch the default skin to Vector?

Post by chase »

Adding the bug for easy tracking: https://bugzilla.wikimedia.org/show_bug.cgi?id=26204

I think their fix is missing a comma.

I had to update SyntaxHighlight_GeSHi to the latest. The style info wasn't the same so the fix didn't work.

I also reapplied Combuster's additional asm keywords so everything should be working like before but now look okay in FireFox.

Note that they changed the recommended usage to <syntaxhighlight lang="c"></syntaxhighlight> instead of <source lang="c"></source> because source tags can occur inside of some languages. The old syntax still works. See: http://www.mediawiki.org/wiki/Extension ... ight_GeSHi
Post Reply